Add Plan Trip Button to Advanced Mode Settings Page #1244
Conversation
There was a problem hiding this comment.
I fixed both my and Josh's comments, @josh-willis-arcadis please look closely at my comments too to make sure they're actually fixed, since I was the one who fixed them I'd like to make sure they get a second look.
There was a problem hiding this comment.
The changes look great! One thing I noticed is that if you uncheck every mode and then click "Plan Trip," you get an error message, followed by the "Preferences Saved" toast, and the advanced panel closes. If there is an error, I believe we shouldn't close the panel or display the toast.
| gap: 0.5em; | ||
| background-color: var(--main-base-color, ${blue[900]}); | ||
| border: 0; | ||
| width: 45%; |
There was a problem hiding this comment.
super nit picky but from widths 992px - 1058px the trip text gets pushed to a new line. change the width to like 47% to fit the text on a single line.
There was a problem hiding this comment.
Really clean, thank you!!
|
@josh-willis-arcadis really good point about the toast. I went ahead and adjusted when the toast displays - now it will only happen when the user closes the panel and returns to the home page, and not when they click "plan trip" |
|
@josh-willis-arcadis @daniel-heppner-ibigroup thank you both so much for the help on this one! |
amy-corson-ibigroup
merged commit 5ed48dc
into
master-trip-form-update
Description:
PR Checklist: